Re: Request to be maintainer of Spreadsheet_Excel_Writer package
| From: | Christian Weiske | Date: | Mon, 03 Aug 2009 12:10:20 +0000 |
| Subject: | Re: Request to be maintainer of Spreadsheet_Excel_Writer package | ||
| References: | 1 2 3 | Groups: | php.pear.qa |
| Request: | Send a blank email to pear-qa+get-5389@lists.php.net to get a copy of this message | ||
Hello Progi,
> Thank you for your discouragement which is really realistic. But like
> I need it for my job, I improve it and want it to give it open source.
> And I keep an eye on this package OpenDocument but I don't want
> contribute while the version 0.3.0 isn't implemented.
>
> I have contributed to Wikini, for improving the XHTML-valid support.
> But my main code isn't public because it owns to my company. I use
> principally these packages : HTML_QuickForm,
> HTML_QuickForm_advmultiselect, HTML_Template_PHPLIB, HTTP_Session2,
> MDB2, MDB2_Driver_pgsql, Mail, Net_SMTP, Spreadsheet_Excel_Writer. I
> have personnally a preference over file formats.
Don't let David discourage you too much - I'd love to see bug fixing in
Spreadsheet_Excel_Writer. I'm willing to step in and help you getting your patches into SVN;
mentor you a bit if you'd like.
First action is always to take the bug, find out what's wrong and fix that. Attach the patch
(against current svn) to the bug. Notify me or someone else to review. Then, we'll either note
things you should fix or give it a go.
A big problem is tests here. You should have a reproducing testcase for the bug, and state in which
excel version it fails. The fixed code should not make excel crash or support the feature. I think a
global test file that makes use of *every* feature and could be viewed and checked would be
helpful.. You could also try to port the changes in the perl version back to our implementation.
--
Regards/Mit freundlichen Grüßen
Christian Weiske