Re: unmaintained package Net_IDNA
| From: | Daniel O'Connor | Date: | Sat, 08 Aug 2009 12:18:30 +0000 |
| Subject: | Re: unmaintained package Net_IDNA | ||
| References: | 1 2 | Groups: | php.pear.qa |
| Request: | Send a blank email to pear-qa+get-5406@lists.php.net to get a copy of this message | ||
>
> > I'd like to maintain the package Net_IDNA, I think it's a vital
> > component and can no longer stay unmaintained. Also there are other
> > packages depending on it (validate).
> >
> > With the focus on webhosting and domain services I used the package
> > Net_IDNA for a while now and feel the need to improve and maintain the
> > package - if you let me :)
>
Welcome :D
A great place to add some value to the package would be to implement some
basic unit test coverage.
http://pear.php.net/bugs/bug.php?id=16466
The great thing about this package is you can pretty simply make a few core
test cases in phpunit, and use a data provider to feed in the in/out/etc.
IE:
class Net_IDNATest {
public function readCSV() {
// load and parse a CSV containing lots of test cases from
//
http://www.gnu.org/software/libidn/draft-josefsson-idn-test-vectors.html#anchor6
}
/** @dataprovider readCSV */
public function testShouldConvertStringToIDNA($in, $expected) {
$result = Net_IDNA::doStuff($in);
$this->assertSame($expected, $result);
}
}
You can read more about the specifics of this with:
1. Test data
http://www.gnu.org/software/libidn/draft-josefsson-idn-test-vectors.html#anchor6
2. http://www.phpunit.de/manual/3.2/en/writing-tests-for-phpunit.html
Come chat on IRC (efnet.org #pear) if you like :)