Re: Net_Dict unmaintained

On Sun, Dec 13, 2009 at 09:40:39AM +0000, Ken Guest wrote: > There is something to do with Net_Dict, you could bring the code for > it up to Standard: > > > http://pear.php.net/bugs/search.php?cmd=display&package_name[]=Net_Dict&status=OpenFeedback&bug_type=Bugs > > k. Those are easy enough - find the diff to http://svn.php.net/repository/pear/packages/Net_Dict/trunk/Net attached. There were two I didn't "fix": 350 | ERROR | Method name "Net_Dict::SASLAuth" is not in camel caps format 363 | ERROR | Method name "Net_Dict::SASLResp" is not in camel caps format I think the code sniffer is wrong here - SASLFoo is the right name for these methods IMO, because they're implementing SASL. Probably the sweetest irony in this process is that PHP_CodeSniffer itself does not pass its own test suite (currently showing 20 errors and an impressive 1,428 warnings on the PEAR QA Statuss overview).

Attachment: [text/x-diff] dict.patch