Re: Taking over Net_DNS
| From: | Daniel O'Connor | Date: | Mon, 12 Apr 2010 01:02:55 +0000 |
| Subject: | Re: Taking over Net_DNS | ||
| References: | 1 2 3 4 | Groups: | php.pear.qa |
| Request: | Send a blank email to pear-qa+get-5639@lists.php.net to get a copy of this message | ||
On Thu, Apr 8, 2010 at 8:57 AM, Matthew Fonda <matthewfonda@gmail.com>wrote:
> On Mon, Apr 5, 2010 at 12:07 PM, Ian Pye <ianpye@gmail.com> wrote:
>
> > Hey,
> >
> > Here you go: https://pear.php.net/bugs/bug.php?id=11665
>
>
> Hi Ian,
>
> Please ensure your patch adheres to the PEAR coding standards.
> See http://pear.php.net/manual/en/standards.php
>
>
Just to expand on that - we're about to pick on you a lot re coding
standards and some of the approach you've taken when implementing your
class.
We're not being nasty; we're just looking for a few common traits that lead
to maintainable code.
http://www.youtube.com/watch?v=wEhu57pih5w
is a great watch to understand
why we're on about no-work-in-constructor, unit testings, why we think
global state is bad, etc.
Please do give it another shot, we're keen to have patches :)
-Daniel