Re: Taking over Net_DNS

Thanks for the encouragement. I re-submitted a patch, which removes some of the most egregious faults. I don't see any other Unit tests in the NET_dns package -- am I not looking in the right place? Ian On Sun, Apr 11, 2010 at 6:02 PM, Daniel O'Connor <daniel.oconnor@gmail.com> wrote: > > > On Thu, Apr 8, 2010 at 8:57 AM, Matthew Fonda <matthewfonda@gmail.com> > wrote: >> >> On Mon, Apr 5, 2010 at 12:07 PM, Ian Pye <ianpye@gmail.com> wrote: >> >> > Hey, >> > >> > Here you go: >> > https://pear.php.net/bugs/bug.php?id=11665 >> >> >> Hi Ian, >> >> Please ensure your patch adheres to the PEAR coding standards. >> See http://pear.php.net/manual/en/standards.php >> > > Just to expand on that - we're about to pick on you a lot re coding > standards and some of the approach you've taken when implementing your > class. > We're not being nasty; we're just looking for a few common traits that lead > to maintainable code. > > http://www.youtube.com/watch?v=wEhu57pih5w is a great watch to > understand > why we're on about no-work-in-constructor, unit testings, why we think > global state is bad, etc. > > Please do give it another shot, we're keen to have patches :) > -Daniel >