Re: Re: cvs: php4 /pear DB.php /pear/DBcommon.phperror.phpmysql.php result.php warning.php

Quoting Sebastian Bergmann <sb@sebastian-bergmann.de>: > Hm, I did this because I'm used to the concept of one class per file from > - don't shoot me - Java. It sounds logical to me, but in the other hand > your right, although I thought (and hoped) that performance issues related to > multible disc accesses would be neglectable. I'm interested in other people's thoughts on this one - it certainly makes sense to in general split classes out into new files. But some classes - like PEAR:: and PEAR_Error:: - are core functionality as well as being closely related, so it makes sense to keep them in the same file. I don't really know what the performance factors are; I imagine that modern OS's disk caching should take care of most of it, but not at least thinking about it and trying to reduce disk hits seems irresponsible to me. > Why didn't you complain about that before? Math::Math_Fraction, Math/Util, > Benchmark::Timer and Benchmark::Benchmark_Iterate are formatted the same > way. Sorry - I didn't mention it because I haven't used those classes, so I haven't looked at them closely. > Again, we can revert that. I'm _very_ much in favor of this; those spaces are simply adding space to every line with _no_ additional meaning. -chuck -- Charles Hagenbuch, <chuck@horde.org> "If you can't stand the heat, get out of the chicken!" - Baby Blues