Re: Account request for vdump extension

Hi, On Sun, 2012-12-16 at 00:45 +0100, Jille Timmermans wrote: > Hello list, > > I would like to have the vdump extension listed in PECL. The idea is > quite simple: It adds a function vdump_dump($file) which allows the > programmer to dump all variables to $file which can be a great aid in > debugging. > > The code can be found at https://github.com/hexon/php-vdump. I myself would in most situations prefer to use a debugger like xdebug to do this but well nontheless I think this could be added. But a few comments: 1) What's the license? The code carries no license, neither do you state in this mail. 2) Have you looked into php_var_export_ex() from php_var.h, I think you might use it instead of your own solution in vdump_add_zval() 3) Your php_vdump.h is relatively long. In general it is good practice to keep it small as it will be included from main/builtin_functions.c if the extension is built statically. 4) Having #define _GNU_SOURCE is always a bit suspicious. I don't see it's needed (might have missed some libc call though) 5) I don't think MINFO is a good place for credits (while this is pecl which is less strict and even in core we have examples doing that...) johannes