Re: Account request for vdump extension
| From: | Jille Timmermans | Date: | Fri, 04 Jan 2013 10:40:16 +0000 |
| Subject: | Re: Account request for vdump extension | ||
| References: | 1 2 3 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-10160@lists.php.net to get a copy of this message | ||
Op 04-01-13 11:08, Jille Timmermans schreef:
1) What's the license? The code carries no license, neither do you state in this mail.I will look into that. I've added the PHP license.
3) Your php_vdump.h is relatively long. In general it is good practice to keep it small as it will be included from main/builtin_functions.c if the extension is built statically.IIRC it was mostly auto-generated by ext_skel but I will trim it down as far as possible. I've removed the useless defines.
Updated code is at https://github.com/hexon/php-vdump5) I don't think MINFO is a good place for credits (while this is pecl which is less strict and even in core we have examples doing that...)I will remove it. Done.