Re: Hello, I want to send a new log extension, Thank you.
| From: | Johannes Schlüter | Date: | Sun, 22 Jun 2014 20:01:41 +0000 |
| Subject: | Re: Hello, I want to send a new log extension, Thank you. | ||
| References: | 1 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-11923@lists.php.net to get a copy of this message | ||
Hi,
On Sun, 2014-06-22 at 16:26 +0800, Neeke Gao wrote:
> This email will introduce a log extension:
> https://github.com/Neeke/SeasLog
Few small comments:
* I think a new logger should play nice with the PSR-3 Logger
interface
https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-3-logger-interface.md
https://github.com/php-fig/log
* From a really quick review I saw you where using TSRMLS_FETCH()
in some PHP_FUNCTION, this won't compile in tsrm mode.
(duplicate tsrmls declaration)
* this code in PHP_FUNCTION (seaslog_analyzer_detail) looks
strange:
if (type == SEASLOG_TYPE_INFO){
type = SEASLOG_TYPE_INFO;
}else if(type == SEASLOG_TYPE_WARN){
type = SEASLOG_TYPE_WARN;
...
This is no proper review, though.
johannes