Re: Hello, I want to send a new log extension, Thank you.

Thank you Johannes: Thanks for your comments,I will thank about that,and would fix it ASAP if reasonable. ps: "Neeke" is my avatar ,thank you again. 2014-06-23 4:01 GMT+08:00 Johannes Schlüter <johannes@schlueters.de>: > Hi, > > On Sun, 2014-06-22 at 16:26 +0800, Neeke Gao wrote: > > This email will introduce a log extension: > https://github.com/Neeke/SeasLog > > Few small comments: > > * I think a new logger should play nice with the PSR-3 Logger > interface > > > https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-3-logger-interface.md > https://github.com/php-fig/log > * From a really quick review I saw you where using TSRMLS_FETCH() > in some PHP_FUNCTION, this won't compile in tsrm mode. > (duplicate tsrmls declaration) > * this code in PHP_FUNCTION (seaslog_analyzer_detail) looks > strange: > if (type == SEASLOG_TYPE_INFO){ > type = SEASLOG_TYPE_INFO; > }else if(type == SEASLOG_TYPE_WARN){ > type = SEASLOG_TYPE_WARN; > ... > > This is no proper review, though. > > johannes > > >