Re: Hello, I want to send a new log extension, Thank you.

I'm very sorry, I have been spent in the hospital last week, really do not have adequate timeto process and upgrade. (my wife just gave me a baby boy, thank one's stars) Some problems of Johannes mentioned above, I have been documented, and modify a part. The remaining part of, I will as soon as possible in a small version of the next iterativelyupgrade. That part is done is: Https://github.com/Neeke/SeasLog/issues/13 Https://github.com/Neeke/SeasLog/issues/14 The iteration in the next version of the upgrade is: Https://github.com/Neeke/SeasLog/issues/15 2014-06-23 10:04 GMT+08:00 Neeke Gao <ciogao@gmail.com>: > Thank you Johannes: > > Thanks for your comments,I will thank about that,and would fix it ASAP if > reasonable. > > ps: "Neeke" is my avatar ,thank you again. > > > > 2014-06-23 4:01 GMT+08:00 Johannes Schlüter <johannes@schlueters.de>: > > Hi, >> >> On Sun, 2014-06-22 at 16:26 +0800, Neeke Gao wrote: >> > This email will introduce a log extension: >> https://github.com/Neeke/SeasLog >> >> Few small comments: >> >> * I think a new logger should play nice with the PSR-3 Logger >> interface >> >> >> https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-3-logger-interface.md >> https://github.com/php-fig/log >> * From a really quick review I saw you where using TSRMLS_FETCH() >> in some PHP_FUNCTION, this won't compile in tsrm mode. >> (duplicate tsrmls declaration) >> * this code in PHP_FUNCTION (seaslog_analyzer_detail) looks >> strange: >> if (type == SEASLOG_TYPE_INFO){ >> type = SEASLOG_TYPE_INFO; >> }else if(type == SEASLOG_TYPE_WARN){ >> type = SEASLOG_TYPE_WARN; >> ... >> >> This is no proper review, though. >> >> johannes >> >> >> >