Re: Re: http extension

Hey Mike, I just took a quick peek; here are my comments: PHP_HTTP_API STATUS _http_send_file(zval *zfile TSRMLS_DC) If you're exporting an API function, you probably shouldn't prefix it with an underscore, but should instead prefix it with php_, so PHP_HTTP_API STATUS php_http_send_file(zval *zfile TSRMLS_DC) is "better". Also, STATUS there feels like it might collide with a define under windows; it might be better to come up with a "namespaced" variation of it. Aside from that, you code looks nice and clean, although I haven't really looked at it in depth. Hopefully Sara will get a chance to look through your code and look at the http-ish stuff. --Wez. On Thu, 06 Jan 2005 16:12:19 +0100, Michael Wallner <mike@php.net> wrote: > I wrote: > > > You can have a look at the sources here: > > http://cvs.iworks.at/cvs.php/ext/http > > > > Installable pear package is available here: > > http://dev.iworks.at/ext-http/http-0.1.0.tgz > > Don't hesitate to comment :) > > Regards, > Michael > > -- > PECL development discussion Mailing List (http://pecl.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > >