Re: http extension

Wez Furlong wrote:

If you're exporting an API function, you probably shouldn't prefix it with an underscore, but should instead prefix it with php_, so PHP_HTTP_API STATUS php_http_send_file(zval *zfile TSRMLS_DC) is "better".

I wouldn't mind to prefix them with php, I just want to note that they are already accessible without underscores (TSRM safe macros in php_http_api.h).

Also, STATUS there feels like it might collide with a define under windows; it might be better to come up with a "namespaced" variation of it.

I just introduced that type to make more obvious what a function's gonna return. Would PHP_STATUS be ok? (LXR doesn't know it (yet)).

Aside from that, you code looks nice and clean, although I haven't really looked at it in depth. Hopefully Sara will get a chance to look through your code and look at the http-ish stuff.

Well then, thanks a lot. Regards, Michael