Re: Proposal for new extension: augeas
| From: | Kalle Sommer Nielsen | Date: | Sun, 15 Nov 2009 22:27:32 +0000 |
| Subject: | Re: Proposal for new extension: augeas | ||
| References: | 1 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-6778@lists.php.net to get a copy of this message | ||
Hi Pedro
2009/11/15 Pedro Padron <pgpadron@gmail.com>:
> Hi there!
> I've read the CODING_STANDARDS and I guess the code complies to it. If
> you find anything weird, please let me know =)
You are having a variable declaring thats not in the top, which isn't
C compatible but its just minor (augeas.c:212).
Another thing I noticed is that you have array_init(return_value)
twice in the Augears::match() where only the latter one is needed.
Else I would wait for a few other reviews before requesting an
SVN+Pecl account =)
--
regrads,
Kalle Sommer Nielsen
kalle@php.net