Re: Proposal for new extension: augeas

I have made some changes so far: - added AugeasException class - all errors were converted to exceptions - (a few) tests were added (phpunit tests) - augeas resource type was removed. instead, the Augeas object "inherits" zend_object: typedef struct _php_augeas_object { zend_object zo; augeas *augeas; } php_augeas_object; - added package.xml Would anyone else like to review this package? Thanks! 2009/11/16 Pedro Padron <pgpadron@gmail.com>: > Hi Kalle! > > Thanks for the feedback, I've already fixed those issues and committed them. > >> You are having a variable declaring thats not in the top, which isn't >> C compatible but its just minor (augeas.c:212). > > resource_id is now declared in the beginning of the function > > http://github.com/ppadron/php-augeas/commit/d29a24286fb8633c2359514a42f3b43c66626e60 > >> Another thing I noticed is that you have array_init(return_value) >> twice in the Augears::match() where only the latter one is needed. > > removed duplicated array_init call in Augeas::match() > > http://github.com/ppadron/php-augeas/commit/7422b147a3cd1032944928c629a0f4bb61d7cce1