Re: Proposal for new extension: augeas

From: Date: Mon, 16 Nov 2009 03:03:41 +0000
Subject: Re: Proposal for new extension: augeas
References: 1 2  Groups: php.pecl.dev 
Request: Send a blank email to pecl-dev+get-6779@lists.php.net to get a copy of this message
Hi Kalle! Thanks for the feedback, I've already fixed those issues and committed them. > You are having a variable declaring thats not in the top, which isn't > C compatible but its just minor (augeas.c:212). resource_id is now declared in the beginning of the function http://github.com/ppadron/php-augeas/commit/d29a24286fb8633c2359514a42f3b43c66626e60 > Another thing I noticed is that you have array_init(return_value) > twice in the Augears::match() where only the latter one is needed. removed duplicated array_init call in Augeas::match() http://github.com/ppadron/php-augeas/commit/7422b147a3cd1032944928c629a0f4bb61d7cce1

« previous php.pecl.dev (#6779) next »