Re: PHP binding for LibYAML
| From: | Bryan Davis | Date: | Fri, 27 Nov 2009 20:33:03 +0000 |
| Subject: | Re: PHP binding for LibYAML | ||
| References: | 1 2 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-6854@lists.php.net to get a copy of this message | ||
Alexey Zakhlestin wrote:
> I had to do some tweaks (patch attached) to compile it using
> php-5.3-zts, but it works :)
Thanks for the patch. It looks like I got pretty sloppy in the emit
section of the module with the TSRMLS markers.
> the only problem with current code is that it is GNU-formatted. It has
> to be converted to PECL coding standards
I know that the php standard calls for tab indention rather than spaces.
Other than that what formatting changes would you like to see?
Bryan
--
The moral is that coding standards are so bad that security flaws are
this common. -- Bruce Schneier
Attachment: [application/x-pkcs7-signature] S/MIME Cryptographic Signature smime.p7s
Attachment: [application/x-pkcs7-signature] S/MIME Cryptographic Signature smime.p7s