Re: PHP binding for LibYAML
| From: | Alexey Zakhlestin | Date: | Fri, 18 Dec 2009 07:30:50 +0000 |
| Subject: | Re: PHP binding for LibYAML | ||
| References: | 1 2 3 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-6928@lists.php.net to get a copy of this message | ||
On 18.12.2009, at 3:02, Bryan Davis wrote:
> On 11/27/2009 02:39 AM, Alexey Zakhlestin wrote:
>> the only problem with current code is that it is GNU-formatted. It has
>> to be converted to PECL coding standards
>
> I've tried to clean up my coding style to what I interpreted as the PECL
> standard. I ran the code through
indent *.c *.h -kr -ts4 -nlp
> -ci8 as
> a start and then made some manual tweaks.
>
> Since my last announcement I've also implemented merge key support as
> requested by Lukas and made an attempt to support recursive structures
> like self referential arrays using aliases.
>
> If you have some time, could you check the current trunk code at
> http://php-yaml.googlecode.com/svn/trunk/ and let me know if I
> pass
> muster for moving into svn.php.net yet.
looks good.
I wouldn't be that strict on line-lengths, but that's subjective.
waiting for you to resolve your account-issues :)