Re: RE: I'd like to work on AMFEXT

On Thu, 29 Jul 2010 05:05:19 +0100, J. Adams <zardozrocks@gmail.com> wrote:

I tried building the same modified amf.c into the PHP 5.3.3 on my windows machine and it failed. The result:

Creating library Release_TS\php5ts.lib and object Release_TS\php5ts.exp amf.obj : error LNK2001: unresolved external symbol _ZVAL_ADDREF amf.obj : error LNK2001: unresolved external symbol _ZVAL_DELREF amf.obj : error LNK2001: unresolved external symbol _ZVAL_REFCOUNT Release_TS\php5ts.dll : fatal error LNK1120: 3 unresolved externals NMAKE : fatal error U1077: '"D:\Program Files\Microsoft Visual Studio 9.0\VC\Bin \cl.exe"' : return code '0x2'

It should be Z_ADDREF, Z_DELREF and Z_REFCOUNT. I think ZVAL_ADDREF, etc. are PHP 5.2-isms. (I'm not sure why the were renamed, perhaps someone else could shed light on this. In any case, zval_add_ref and zval_ptr_dtor are enough for the majority of cases. zval_ptr_dtor is not adequate for variables not allocated with emalloc, but simple stack-allocated variables generally don't need to have their reference count changed around). -- Gustavo Lopes