Re: I'd like to work on amfext
| From: | j adams | Date: | Thu, 29 Jul 2010 08:58:13 +0000 |
| Subject: | Re: I'd like to work on amfext | ||
| Groups: | php.pecl.dev | ||
| Request: | Send a blank email to pecl-dev+get-7394@lists.php.net to get a copy of this message | ||
As I've mentioned before, I'm very new to PHP. Pierre, I'm not sure I'd be
able to recognize from other projects that _ZVAL_ADDREF is no longer used
between 5.2 and 5.3. 5.2 was not so long ago. Is there some master list of
deprecated macros? The PHP project has so many. I've seen notes like this
one which say that something has been changed:
http://news.php.net/php.pecl.dev/7123
But I don't think it would be very easy to track all these down.
Also, what about keeping compatibility in earlier versions of php? I'd hate
to fix this for php 5.3 and break it for everyone in php 5.2. I've seen
edits like this:
#if PHP_MAJOR_VERSION >= 5
if (zend_lookup_class(Z_STRVAL_P(
zClassname), Z_STRLEN_P(zClassname), &classEntry TSRMLS_CC) != SU$
#else
if(zend_hash_find(EG(class_table),
Z_STRVAL_P(zClassname), Z_STRLEN_P(zClassname), (void **) &class$
#endif
Is there a coding standard for checkin major and minor versions?
Forgive me for the noobish questions. I want to do this right.