Re: pecl dev intro - bob - geoipo

hi, On Mon, Oct 24, 2011 at 2:27 PM, Olivier Hill <ohill@php.net> wrote: > Hello all, > > Since some people have answered first, I can now openly give my opinion ;) > > I'm against having that extension into PECL. I'd to reconsider. See my comments below. > Regarding point #1, you can configure the data dir, the ini option is > missing documentation, I should be adding that. It should be nicer to have this option as part of the API. ini settings should be avoided, generally speaking, for such things. > Regarding #2, OO alone doesn't give you much. GeoIP is a very simple > extension. It goes back to the debate of string functions (PHP core) > should be OO. Yes it would be nice, no it is far from being necessary. As I tend to agree, it is very easy to add it in the extension itself while keeping the procedural API and being fully BC. See the zip extension, I did exactly that there. > If an OO interface can be build on top of the current extension, I'm > willing to accept patches. That's what I ask for here, a patch to add the OO API on top of what is there now and another one for the DB dir. Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org