Re: pecl dev intro - bob - geoipo
| From: | Pierre Joye | Date: | Mon, 24 Oct 2011 16:32:41 +0000 |
| Subject: | Re: pecl dev intro - bob - geoipo | ||
| References: | 1 2 3 4 5 6 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-8760@lists.php.net to get a copy of this message | ||
hi,
On Mon, Oct 24, 2011 at 4:20 PM, Bob Majdak Jr <bob@opsat.net> wrote:
> The PHP INI setting does not work if you have one site that has licensed databases and another
> using free databases on the same server. If ini_set() would work afte the fact, then maybe, but it
> does not. But I am glad after all these years it has come to your attention. I originally was just
> going to submit a patch for just that... but.
Right, that's the main reason why ini settings are not good for such things..
> I can submit a patch that would literally 100% of your code with this object, sure. I had to
> refactor things to get the features that were needed and I also made the object actually PHPesque
> making GeoIP fun to use, versus having to stack weird named functions to get what you want.
The changes should be minimal to the existing code but to add OO
declarations and getthis. See the zip extension for an example of
sharing the function and method implementation.
Cheers,
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org