RE: [PECL-DEV] Updating erroneous package solr-PECL 1.0.1

Ferenc is absolutely right. I don't think that there is any package were tests do pass, when the compilation fails. > Ferenc, just let other talk for themselves, we do not need a > translator here. There are reasons behing this question. > > On Mon, Nov 28, 2011 at 11:15 AM, Ferenc Kovacs <tyra3l@gmail.com> wrote: > > No, he is saying, that he can't provide a test which can catch this kind of > > problem in the future, because the extension was not compiling with 5..2 > > without the patch, hence no test could be run against. > > On Mon, Nov 28, 2011 at 11:04 AM, Pierre Joye <pierre.php@gmail.com> wrote: > >> > >> Are you saying that even with the patch you provided (and it has > >> applied) the tests do not pass? Then we have another problem here. > >> > >> On Mon, Nov 28, 2011 at 10:42 AM, Alex PHP <alexphp2000@hotmail.com> > >> wrote: > >> > > >> > Hello Pierre, > >> > > >> > I was not talking about the tests from the tests-directory. Everyone of > >> > those tests fails, > >> > because as said the package is not even compileable. > >> > > >> > Greetings, > >> > Alex > >> > > >> >> hi Alex, > >> >> > >> >> Please update the tests as well with the patch, so this won't happen > >> >> again :) > >> >> > >> >> Cheers, > >> >> > >> >> On Mon, Nov 28, 2011 at 10:16 AM, Alex PHP <alexphp2000@hotmail.com> > >> >> wrote: > >> >> > > >> >> > > >> >> > Hello Israel, > >> >> > > >> >> > two weekends have elapsed now and there is still no corrected > >> >> > package. > >> >> > What's up, do you need any help? > >> >> > > >> >> > Your tests haven't recognized the failure last time so I don't > >> >> > think > >> >> > that they are trustworthy. > >> >> > > >> >> > Greetings, > >> >> > Alex > >> >> > > >> >> >> Alex, > >> >> >> > >> >> >> Thanks a lot for your work. I really do appreciate the effort you > >> >> >> and > >> >> >> everyone else have put into making this happen. > >> >> >> > >> >> >> I will be running tests this weekend for backwards and forward > >> >> >> compatibility. > >> >> >> > >> >> >> At the moment, everything looks good so far so I am not expecting to > >> >> >> have > >> >> >> any problems. > >> >> >> > >> >> >> I will make a new release once my testing is completed this weekend. > >> >> >> > >> >> >> Thanks again. > >> >> >> > >> >> >> On Wed, Nov 16, 2011 at 4:12 AM, Alex PHP > >> >> >> <alexphp2000@hotmail.com> > >> >> >> wrote: > >> >> >> > >> >> >> > > >> >> >> > Hello all, > >> >> >> > > >> >> >> > I finally received an answer from the package maintainer Israel > >> >> >> > of > >> >> >> > solr-PECL with help of > >> >> >> > Pierre and Ferenc (thanks again!). > >> >> >> > > >> >> >> > Israel will make time this weekend to make a release once he > >> >> >> > runned his > >> >> >> > tests to make sure > >> >> >> > it did not break anything. So I am looking forward that all PHP > >> >> >> > 5.2 users > >> >> >> > can finally use solr > >> >> >> > with PHP. > >> >> >> > > >> >> >> > Greetings, > >> >> >> > Alex > >> >> >> > > >> >> >> > > From: alexphp2000@hotmail.com > >> >> >> > > To: pecl-dev@lists.php.net > >> >> >> > > Date: Thu, 10 Nov 2011 14:04:00 +0000 > >> >> >> > > Subject: [PECL-DEV] Someone who can apply a patch to a > >> >> >> > > PECL-package? > >> >> >> > > > >> >> >> > > > >> >> >> > > Hello all, > >> >> >> > > > >> >> >> > > the PECL-package solr (http://pecl.php.net/package/solr) > >> >> >> > > should > >> >> >> > > work > >> >> >> > with PHP 5.2 and higher accordingly to > >> >> >> > > the requirements, but because of a bug it is actually only > >> >> >> > > working with > >> >> >> > PHP 5.3, see bug report > >> >> >> > > > >> >> >> > > https://bugs.php.net/bug.php?id=59808 > >> >> >> > > > >> >> >> > > I have already supplied a patch at this bug report which > >> >> >> > > just > >> >> >> > > changes 2 > >> >> >> > lines, so that it can be compiled with > >> >> >> > > PHP 5.2 and tried to contact the maintainer of the package > >> >> >> > > Israel now > >> >> >> > for over a month via his several email- > >> >> >> > > addresses, the solr mailing list and the bug tracker, but > >> >> >> > > haven't > >> >> >> > received any reply yet. > >> >> >> > > > >> >> >> > > So can someone please apply the patch to the current > >> >> >> > > version > >> >> >> > > 1.0.1 of > >> >> >> > solr-PECL and provide a new corrected > >> >> >> > > version of the PECL-package. The patch can be found here: > >> >> >> > > > >> >> >> > > > >> >> >> > > >> >> >> > > >> >> >> > https://bugs.php.net/patch-display.php?bug_id=59808&patch=peclsolr.patch&revision=latest > >> >> >> > > > >> >> >> > > Thanks, > >> >> >> > > Alex > >> >> >> > > > >> >> >> > > > >> >> >> > > >> >> >> > > >> >> >> > >> >> >> > >> >> >> > >> >> >> -- > >> >> >> °O° > >> >> >> "Good Enough" is not good enough. > >> >> >> To give anything less than your best is to sacrifice the gift. > >> >> >> Quality First. Measure Twice. Cut Once. > >> >> >> http://www.israelekpo.com/ > >> >> > > >> >> > >> >> > >> >> > >> >> -- > >> >> Pierre > >> >> > >> >> @pierrejoye | http://blog.thepimp.net | > >> >> http://www.libgd.org > >> >> > >> >> -- > >> >> PECL development discussion Mailing List (http://pecl.php.net/) > >> >> To unsubscribe, visit: > >> >> http://www.php.net/unsub.php > >> >> > >> > > >> > >> > >> > >> -- > >> Pierre > >> > >> @pierrejoye | http://blog.thepimp.net | > >> http://www.libgd.org > >> > >> -- > >> PECL development discussion Mailing List (http://pecl.php.net/) > >> To unsubscribe, visit: http://www.php.net/unsub.php > >> > > > > > > > > -- > > Ferenc Kovács > > @Tyr43l - http://tyrael.hu > > > > > > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | > http://www.libgd.org > > -- > PECL development discussion Mailing List (http://pecl.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php >