Re: Updating erroneous package solr-PECL 1.0.1

Hi, I did some fix on the trunk version to make it compile and I hope work on PHP5.4 without braking compatibility. I don't have a solr env on this laptop so it was not possible to launch all the tests but if someone have it, i'll fix pending issues. P. On 28 November 2011 12:16, Israel Ekpo <israelekpo@gmail.com> wrote: > Pierre, > > I agree with your assessment as well. > > I have to make sure that it works on 5.2, 5.3 and 5.4 before cutting a > release. > > Right now, the current release (1.0.1) works on 5.3 and 5.4 but the code in > trunk does not. > > The objective is to correct the issues in trunk so that we can compile it > successfully on 5.2 through 5.4 > > I will keep you posted and will let you know where we stand by tomorrow > afternoon > > > On Mon, Nov 28, 2011 at 12:10 PM, Pierre Joye <pierre.php@gmail.com> > wrote: > > > hi Israel! > > > > Thanks for the reply! > > > > That's exactly what I was wondering, firing releases to fire release > > makes no sense if it is not tested on all supported php versions. > > > > Cheers, > > > > On Mon, Nov 28, 2011 at 6:01 PM, Israel Ekpo <israelekpo@gmail.com> > wrote: > > > Guys, > > > > > > The current version in trunk is not compiling. > > > > > > I am working on resolving this by tomorrow evening and once I resolve > the > > > errors, I will create a release. > > > > > > These are the compilation errors that I am getting with PHP 5.3.0 > > > > > > /home/iekpo/labs/pecl-solr/solr_functions_helpers.c:1127:6: error: #if > > with > > > no expression > > > > > > Thank you for your patience. > > > > > > > > > > > > On Mon, Nov 28, 2011 at 5:34 AM, Pierre Joye <pierre.php@gmail.com> > > wrote: > > >> > > >> On Mon, Nov 28, 2011 at 11:32 AM, Alex PHP <alexphp2000@hotmail.com> > > >> wrote: > > >> > I don't think that there is any package were > > >> > tests do pass, > > >> > when the compilation fails. > > >> > > >> That was not my question. And it is rather obvious that tests cannot > > >> be ran if the builds fail... > > >> > > >> My question is: Now that your patch has been applied, do the tests > pass? > > >> > > >> -- > > >> Pierre > > >> > > >> @pierrejoye | http://blog.thepimp.net | > > >> http://www.libgd.org > > > > > > > > > > > > -- > > > °O° > > > "Good Enough" is not good enough. > > > To give anything less than your best is to sacrifice the gift. > > > Quality First. Measure Twice. Cut Once. > > > http://www.israelekpo.com/ > > > > > > > > > > > -- > > Pierre > > > > @pierrejoye | http://blog.thepimp.net | > > http://www.libgd.org > > > > > > -- > °O° > "Good Enough" is not good enough. > To give anything less than your best is to sacrifice the gift. > Quality First. Measure Twice. Cut Once. > http://www.israelekpo.com/ >