Re: Updating erroneous package solr-PECL 1.0.1

hi Israel! Thanks for the reply! That's exactly what I was wondering, firing releases to fire release makes no sense if it is not tested on all supported php versions. Cheers, On Mon, Nov 28, 2011 at 6:01 PM, Israel Ekpo <israelekpo@gmail.com> wrote: > Guys, > > The current version in trunk is not compiling. > > I am working on resolving this by tomorrow evening and once I resolve the > errors, I will create a release. > > These are the compilation errors that I am getting with PHP 5.3.0 > > /home/iekpo/labs/pecl-solr/solr_functions_helpers.c:1127:6: error: #if with > no expression > > Thank you for your patience. > > > > On Mon, Nov 28, 2011 at 5:34 AM, Pierre Joye <pierre.php@gmail.com> wrote: >> >> On Mon, Nov 28, 2011 at 11:32 AM, Alex PHP <alexphp2000@hotmail.com> >> wrote: >> > I don't think that there is any package were >> > tests do pass, >> > when the compilation fails. >> >> That was not my question. And it is rather obvious that tests cannot >> be ran if the builds fail... >> >> My question is: Now that your patch has been applied, do the tests pass? >> >> -- >> Pierre >> >> @pierrejoye | http://blog.thepimp.net | >> http://www.libgd.org > > > > -- > °O° > "Good Enough" is not good enough. > To give anything less than your best is to sacrifice the gift. > Quality First. Measure Twice. Cut Once. > http://www.israelekpo.com/ > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org