RE: DBX tests failing
| From: | Derick Rethans | Date: | Mon, 07 Oct 2002 08:03:12 +0000 |
| Subject: | RE: DBX tests failing | ||
| References: | 1 | Groups: | php.qa |
| Request: | Send a blank email to php-qa+get-5984@lists.php.net to get a copy of this message | ||
On Mon, 7 Oct 2002, Marc Boeren wrote:
>
> Hi,
>
> > > How do I test if the db is running so I can skip it? If I
> > > skip because dbx_connect fails, is that because the db
> > > is not running, or the dbx_connect is buggy?
>
> > Yeah, that's true... but as only very few people have those
> > tests set-up it will fail for like 90% of the testers. We want to
> > move to the point that nothing is allowed to fail before we
> > release, so it's definitely not a good point if all DB (not only
> > DBX) tests fail if they're not setup.
>
> > Does anybody else have an idea?
>
> How about a 'make test --test-dbx-too' or something similar, in which case I
> can skip it if some var is not set (which would be the default)?
> Or even easier, I create an include-file that just says $skip_test = true
> that a tester can set to false, or perhaps an array that specifies which
> files to skip and which to run?
With all due respect that's too much of a hassle. Everybody (including
the "stupid" users) must be able to run "make test" without having to
set variables, includes or anything and still get reliable test results.
I think it would make sense to skip if dbx_connect() fails in this case.
If you need dbx it's very obvious that you check whether the tests were
skipped or not...
(can you please cc php-qa@lists.php.net too?)
regards,
Derick
--
---------------------------------------------------------------------------
Derick Rethans http://derickrethans.nl/
JDI Media Solutions http://www.jdimedia.nl/
---------------------------------------------------------------------------