RE: DBX tests failing

Hi, >> Or even easier, I create an include-file that just says $skip_test = true >> that a tester can set to false > With all due respect that's too much of a hassle. Everybody > (including the "stupid" users) must be able to run "make test" > without having to set variables, includes or anything and still > get reliable test results. Well, the "stupid" users would not test dbx anyway, and they would just 'make test' and it would work. Only people that create a test-setup for dbx (not many, I think) would have to change the include-file. They should change that anyway so the settings are correct for their specific test-database. There is already an include-file (dbx_test.p) to specify database-settings, and the default setting here is $connection = DBX_MYSQL; If I change that to $connection = NULL; and a remark to set it to the proper database for testing purposes, then I can easily change the scripts to check for $connection and skip if it is NULL. > I think it would make sense to skip if dbx_connect() fails in > this case. I disagree for the simple reason that dbx_connect is one of the functions tested, and so should not be used to determine if the test is to be skipped. > (can you please cc php-qa@lists.php.net too?) Yeah, my mailprogram didn't show the headers so I missed the cc... Cheerio, Marc.