Re: New Tests: imagecreatetruecolor

Rafael Dohms wrote:

Just wrote some more tests today to teste imagecreatetruecolor, since for some reason LCOV indicates it as uncovered imagecreatetruecolor_basic.phpt >> http://pastebin.com/m7d991a9 imagecreatetruecolor_error1.phpt >> http://pastebin.com/m312a91ee imagecreatetruecolor_error2.phpt >> http://pastebin.com/m65840ca0 Can some one look them over for me? and commit them if they are ok?

As a non-gd expert they look OK. I see there is one truecolor.phpt test already and many tests call the function. If you have more time, the parameter type test could also call the function with no parameters and too many parameters, if this is not already covered. You could also add the ===DONE=== stuff mentioned at the bottom of http://qa.php.net/write-test.php Did you not get CVS access just before the VCS migration? (I.e. can you merge them yourself)? Chris -- Blog: http://blogs.oracle.com/opal Twitter: http://twitter.com/ghrd