Re: New Tests: imagecreatetruecolor

On Fri, Jul 17, 2009 at 6:36 PM, Christopher Jones < christopher.jones@oracle.com> wrote: > > > Rafael Dohms wrote: > > Just wrote some more tests today to teste imagecreatetruecolor, since for > > some reason LCOV indicates it as uncovered > > > > imagecreatetruecolor_basic.phpt >> > > http://pastebin.com/m7d991a9 > > imagecreatetruecolor_error1.phpt >> > > http://pastebin.com/m312a91ee > > imagecreatetruecolor_error2.phpt >> > > http://pastebin.com/m65840ca0 > > > > Can some one look them over for me? and commit them if they are ok? > > > > As a non-gd expert they look OK. > > I see there is one truecolor.phpt test already and many tests call the > function. > I'll look at it.. maybe rename it to _basic and recheck mine, LCOV indicaded error needed tests > > If you have more time, the parameter type test could also call the > function with no parameters and too many parameters, if this is not > already covered. > will do and error3 for this > > You could also add the ===DONE=== stuff mentioned at the bottom of > http://qa.php.net/write-test.php > I was not sure about it... will look at it thanks > > Did you not get CVS access just before the VCS migration? (I.e. can > you merge them yourself)? > I do have a SVN account.. not sure if I have karma, Derick mentioned i would need to get karma before commiting tests. Thanks for the feedback Cris! > > Chris > > -- > Blog: http://blogs.oracle.com/opal > Twitter: http://twitter.com/ghrd > -- Rafael Dohms PHP Evangelist and Community Leader http://www.rafaeldohms.com.br http://www.phpsp.org.br