Re: New Tests: imagecreatetruecolor

Ok, I looked over everything, conclusions below On Sat, Jul 18, 2009 at 12:06 AM, Rafael Dohms <listas@rafaeldohms.com.br>wrote: > > On Fri, Jul 17, 2009 at 6:36 PM, Christopher Jones < > christopher.jones@oracle.com> wrote: > >> >> >> Rafael Dohms wrote: >> > Just wrote some more tests today to teste imagecreatetruecolor, since >> for >> > some reason LCOV indicates it as uncovered >> > >> > imagecreatetruecolor_basic.phpt >> >> > http://pastebin.com/m7d991a9 >> > imagecreatetruecolor_error1.phpt >> >> > http://pastebin.com/m312a91ee >> > imagecreatetruecolor_error2.phpt >> >> > http://pastebin.com/m65840ca0 >> > >> > Can some one look them over for me? and commit them if they are ok? >> > >> >> As a non-gd expert they look OK. >> >> I see there is one truecolor.phpt test already and many tests call the >> function. >> > > I'll look at it.. maybe rename it to _basic and recheck mine, LCOV > indicaded error needed tests > > truecolor.phpt test tests imageistruecolor and another function, so i have left it intact and _basic should make it > >> If you have more time, the parameter type test could also call the >> function with no parameters and too many parameters, if this is not >> already covered. >> > > will do and error3 for this > > done! imagecreatetruecolor_error3.phpt >> http://pastebin.com/m255c06cc > >> You could also add the ===DONE=== stuff mentioned at the bottom of >> http://qa.php.net/write-test.php >> > > I was not sure about it... will look at it thanks > > Doc says its recomended for large EXPECT blocks... i only have 4 lines at most... does not seem like an issue. > >> Did you not get CVS access just before the VCS migration? (I.e. can >> you merge them yourself)? >> > > I do have a SVN account.. not sure if I have karma, Derick mentioned i > would need to get karma before commiting tests. > Well the tests are done.. will look for more in LCOV... just point me in the right way and i'll do what i need to get karma Thanks! Cheers. > > Thanks for the feedback Cris! > > >> >> Chris >> >> -- >> Blog: http://blogs.oracle.com/opal >> Twitter: http://twitter.com/ghrd >> > > > > -- > Rafael Dohms > PHP Evangelist and Community Leader > http://www.rafaeldohms.com.br > http://www.phpsp.org.br > -- Rafael Dohms PHP Evangelist and Community Leader http://www.rafaeldohms.com.br http://www.phpsp.org.br