Patch for currently failing SPL tests
| From: | Knut Urdalen | Date: | Thu, 23 Jun 2011 13:02:02 +0000 |
| Subject: | Patch for currently failing SPL tests | ||
| Groups: | php.qa | ||
| Request: | Send a blank email to php-qa+get-65840@lists.php.net to get a copy of this message | ||
Hi,
I've made a patch for the currently failing SPL-tests:
http://people.apache.org/~kurdalen/php/spl-tests-fixed.patch
The failing tests where related to testing getOwner() and getGroup() functions of SplFileInfo- and DirectoryIterator-class. Refactored from using shell_exec() to use fileowner()/filegroup() to retrieve this information.
Since those function also works on Windows I also removed the existing SKIPIF's for Windows. The rationale for that is that we should probably not write platform specific tests if we can avoid it since most PHP-code should be interoperable across platforms.
Hannes helped me getting on board with testing and also recently gave me test karma so if it's ok I'll go ahead and commit this patch.
Regards,
Knut