Re: Patch for currently failing SPL tests
| From: | Johannes Schlüter | Date: | Fri, 24 Jun 2011 13:11:49 +0000 |
| Subject: | Re: Patch for currently failing SPL tests | ||
| References: | 1 | Groups: | php.qa |
| Request: | Send a blank email to php-qa+get-65842@lists.php.net to get a copy of this message | ||
On Thu, 2011-06-23 at 15:02 +0200, Knut Urdalen wrote:
> Hi,
>
> I've made a patch for the currently failing SPL-tests:
> http://people.apache.org/~kurdalen/php/spl-tests-fixed.patch
Going quickly through them I didn't see anything obvious wrong. One
comment though: I like if tests creating temporary files name them after
themselves so if cleaning fails one knows where to look. These are short
enough that the CLEANUP should always work so I assume there are better
places for spending time, but in other cases this might be nice :-)
> Hannes helped me getting on board with testing and also recently gave me
> test karma so if it's ok I'll go ahead and commit this patch.
If you tested them properly go ahead :-)
johannes