Re: Patch for currently failing SPL tests
| From: | Knut Urdalen | Date: | Sat, 25 Jun 2011 04:48:48 +0000 |
| Subject: | Re: Patch for currently failing SPL tests | ||
| References: | 1 2 | Groups: | php.qa |
| Request: | Send a blank email to php-qa+get-65845@lists.php.net to get a copy of this message | ||
On 6/24/11 3:11 PM, Johannes Schlüter wrote:
I like if tests creating temporary files name them after themselves so if cleaning fails one knows where to look. These are short enough that the CLEANUP should always work so I assume there are better places for spending time, but in other cases this might be nice :-) I totally agree :) Patch updated:http://people.apache.org/~kurdalen/php/spl-tests-fixed.patch
If you tested them properly go ahead :-) I run the tests against all active branches (trunk, PHP_5_3 and PHP_5_4).Knut