Re: [PHP4BETA] CVS update: php4/ext/session

From: Date: Sun, 06 Jun 1999 19:55:17 +0000
Subject: Re: [PHP4BETA] CVS update: php4/ext/session
References: 1 2 3 4  Groups: php.version4 
Request: Send a blank email to php-version4+get-1339@lists.php.net to get a copy of this message
On Sun, Jun 06, 1999 at 10:51:31PM +0200, Zeev Suraski wrote: > At 21:44 06/06/99 , Sascha Schumann wrote: > >On Sun, Jun 06, 1999 at 06:39:48PM -0000, andi wrote: > > > Date: Sunday June 6, 1999 @ 14:39 > > > Author: andi > > > > > > Update of /repository/php4/ext/session > > > In directory php:/tmp/cvs-serv11552/ext/session > > > > > > Modified Files: > > > session.c > > > Log Message: > > > - Use PS() everywhere. > > > > > > >I wrote it the way it was on purpose. Don't try to outsmart > >original authors of source code you work on. ;) > > Mind sharing that purpose with the rest of us mortals? :) > I don't like to reinvent the wheel or double code. That is why the session module uses php_rinit_globals not only for ZTS where this function is necessary, but also for non-ZTS where the function is called directly from the startup code. Using PS(x) in php_rinit_globals will work on Windows, because PS(x) is there some_ptr->x. On Unix PS(x) is some_ptr.x which is obviously different and will fail there. -- Regards, Sascha Schumann Consultant

« previous php.version4 (#1339) next »