Re: [PHP4BETA] CVS update: php4/ext/session
| From: | Andi Gutmans | Date: | Mon, 07 Jun 1999 15:34:40 +0000 |
| Subject: | Re: [PHP4BETA] CVS update: php4/ext/session | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.version4 |
| Request: | Send a blank email to php-version4+get-1357@lists.php.net to get a copy of this message | ||
At 12:12 07/06/99 +0200, Sascha Schumann wrote:
On Mon, Jun 07, 1999 at 07:38:40AM +0200, Andi Gutmans wrote: Please explain what I'm screwing up. I didn't notice immediately that you also changed the prototype and hence the parameter passed to the functions. The previous version of session_rinit_globals was already thread safe - it only accessed members of a struct passed by a pointer to it. That is why I don't see a reason to change the function.Well I think we should try and follow this coding standard in all the modules. It'd be best for all of the modules to look alike as much as possible. By the way, we should also hash the session files in some way on the disk and not have one huge directory with all of the session files. For example if the name of the session file is abcdefg it should probably be in a/b/c/d/efg or something like that or performance will go way down. Andi --- Andi Gutmans <andi@zend.com> ICQ: 1568297