Re: [PHP4BETA] CVS update: php4/ext/session
| From: | Sascha Schumann | Date: | Mon, 07 Jun 1999 16:35:26 +0000 |
| Subject: | Re: [PHP4BETA] CVS update: php4/ext/session | ||
| References: | 1 2 3 4 5 6 7 8 9 10 | Groups: | php.version4 |
| Request: | Send a blank email to php-version4+get-1371@lists.php.net to get a copy of this message | ||
On Mon, Jun 07, 1999 at 05:34:40PM +0200, Andi Gutmans wrote:
> At 12:12 07/06/99 +0200, Sascha Schumann wrote:
> >On Mon, Jun 07, 1999 at 07:38:40AM +0200, Andi Gutmans wrote:
> > >
> > > Please explain what I'm screwing up.
> >
> >I didn't notice immediately that you also changed the prototype
> >and hence the parameter passed to the functions. The previous
> >version of session_rinit_globals was already thread safe - it
> >only accessed members of a struct passed by a pointer to it. That
> >is why I don't see a reason to change the function.
>
> Well I think we should try and follow this coding standard in all the
> modules. It'd be best for all of the modules to look alike as much as possible.
>
> By the way, we should also hash the session files in some way on the disk
> and not have one huge directory with all of the session files. For example
> if the name of the session file is abcdefg it should probably be in
> a/b/c/d/efg or something like that or performance will go way down.
>
That is on the TODO.
--
Regards,
Sascha Schumann
Consultant