Re: [PHP4BETA] cvs: /php4/ext/odbc config.h.stub config.m4 php3 _velocis.h php_odbc.c php_odbc.h velocis.c

> I'm getting compilation errors on Windows on php_odbc.h and php_odbc.c, and > it seems to be related to the numerous changes like the following: > > -#if HAVE_SOLID > +#ifdef HAVE_SOLID > > The problem occurs due to the definitions of these constants as "0" in > config.w32.h. > > Question: was this change made solely for cosmetic reasons, and if so, can > it be changed back? Or would it be better to fix config.w32.h? These should definitely be #if's and not #ifdef's, looks like Stig got confused there. By the way, the CVS blame script is great for figuring out who did what/when and why. See: http://bonsai.php.net/bonsai/cvsblame.cgi?file=/php4/ext/odbc/php_odbc.c And put your mouse over the link on line 150. -Rasmus