Re: [PHP4BETA] cvs: /php4/ext/odbc config.h.stub config.m4 php3 _velocis.h php_odbc.c php_odbc.h velocis.c

On Tue, 9 Nov 1999, Stig Bakken wrote: > On Tue, 9 Nov 1999, Rasmus Lerdorf wrote: > > | > These changes were done for consistency. I'll update config.w32.h. > | > | Then you also need to change every single define in php_config.h > > I changed ext/odbc/config.h.stub, from which php_config.h is built, so the > HAVE_NNN symbols used in ext/odbc default to undefined. Or do you mean > something else? Ok, perhaps I am being completely daft here, but all the HAVE_* defines in php_config.h define to either 0 or 1, do they not? ie. a partial copy-paste from it: /* Define if you want the LDAP directory interface */ #define HAVE_LDAP 0 /* Define if you want the MCAL extension */ #define HAVE_MCAL 0 /* define if you want to use the mcrypt extension */ /* #undef HAVE_LIBMCRYPT */ /* define if you want to use the mhash extension */ /* #undef HAVE_LIBMHASH */ #define HAVE_MSQL 0 #define MSQL1 0 #ifndef HAVE_MYSQL #define HAVE_MYSQL 0 #endif /* define if you want to use the oci8 extension */ /* #undef HAVE_LIBOCI8 */ #define HAVE_OCI8 0 #define HAVE_SOLID 0 #define HAVE_IBMDB2 0 #define HAVE_IODBC 0 #define HAVE_ESOOB 0 #define HAVE_UNIXODBC 0 #define HAVE_OPENLINK 0 #define HAVE_ADABAS 0 #define HAVE_CODBC 0 #define HAVE_UODBC 0 #define HAVE_EMPRESS 0 #define HAVE_VELOCIS 0 /* Define if you have the Oracle database client libraries */ #define HAVE_ORACLE 0 /* define if you want to use the PCRE extension */ #define HAVE_PCRE 0 That's what I meant when I said you'd need to change all the other ones as well. We have always used this approach, and if you are going to change the ODBC case to #define blah 1/#undef blah then we should be consistent and do it throughout. Personally I don't see why what we have isn't sufficient. -Rasmus