Re: [PHP4BETA] cvs: /php4/ext/odbc config.h.stub config.m4 php3 _velocis.h php_odbc.c php_odbc.h velocis.c

On Tue, 9 Nov 1999, Stig Bakken wrote: > On Tue, 9 Nov 1999, Rasmus Lerdorf wrote: > > | > I'm getting compilation errors on Windows on php_odbc.h and php_odbc.c, and > | > it seems to be related to the numerous changes like the following: > | > > | > -#if HAVE_SOLID > | > +#ifdef HAVE_SOLID > | > > | > The problem occurs due to the definitions of these constants as "0" in > | > config.w32.h. > | > > | > Question: was this change made solely for cosmetic reasons, and if so, can > | > it be changed back? Or would it be better to fix config.w32.h? > | > | These should definitely be #if's and not #ifdef's, looks like Stig got > | confused there. > > Why should they be #ifs? (Btw, the reason I changed it in the first place > was that the ODBC extension wasn't working because of it.) Because in php_config.h we have: #define HAVE_SOLID 0 when we don't have Solid support. It has always been like that, has it not? An #ifdef we return true which is not what we want in this case. -Rasmus