Re: [PHP4BETA] Re: [PHP-DEV] Should php3_fopen_for_parser change

From:	Zeev Suraski	Date:	Sat, 27 Nov 1999 22:49:43 +0000
Subject:	Re: [PHP4BETA] Re: [PHP-DEV] Should php3_fopen_for_parser change
References:	1 2 3	Groups:	php.version4
Request:	Send a blank email to php-version4+get-6979@lists.php.net to get a copy of this message

There's no question about that; I've been pushing that style since long ago (see the entire ZTS system for a good example). However, it has very little to do with the code in MySQL's do_connect(). Most of MySQL's do_connect() are unique, and generalization wouldn't be proper (for instance, the protection against SIGPIPE, the MySQL-version specific checks for the server being gone). I didn't say it couldn't be improved, but it's not as simple as you make it seem, and it's definitely not a clear cut. Zeev At 14:39 26/11/1999 , Sascha Schumann wrote:

GOOD ============== #ifdef FEATURE #define feature() func_feature() #else #define feature() #endif void some_function() {
    ...
    feature();
    ...
} BAD =============== void some_function() {
    ...
#ifdef FEATURE
    func_feature();
#endif
    ...
} --
          Regards,
                            Sascha Schumann
                                 Consultant

-- Zeev Suraski <zeev@zend.com> http://www.zend.com/