Re: Warnings
| From: | Wojciech Kupiec | Date: | Fri, 02 Sep 2011 09:19:44 +0000 |
| Subject: | Re: Warnings | ||
| References: | 1 2 3 4 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-12099@lists.php.net to get a copy of this message | ||
On 31/08/11 13:08, Paul Dragoonis wrote:
Attachment: [text/x-patch] warning.diff
On Tue, Aug 30, 2011 at 3:28 PM, Paul Dragoonis<dragoonis@gmail.com> wrote:Paul, That is great that you started working on it! I took a look at this and basically the issues I see are: - The text covers image if you shrink the WB window - The image is cut, in some cases if the content is not height enough - I don't think we need to increase common test size - Maybe having a darker background would be nice - The warning box could be shorter I did some changes, see here: http://wojak.u.bitbit.net/warning-20110902.png (I'm using the old image, please publish the new one) The diff is attached, have a look. WojakOn Tue, Aug 30, 2011 at 3:08 PM, Hannes Magnusson <hannes.magnusson@gmail.com> wrote:Here we are, styled it elegantly enough with a nice image on the left. The patch is a diff of doc.css and the new image added. Does the diff view somehow include the image or is that only preview-able via an actual commit? Patch attached. Regards, Paul Dragoonis.On Tue, Aug 30, 2011 at 15:07, Keloran<ava3ar@gmail.com> wrote:I'll style this up in a pretty box nothing too drastic but eye-catching enough.I think the warnings should be made abit more obvious http://uk3.php.net/manual/en/language.types.float.php#warn.float-precision view that in the alpha-styleExcellent catch.
Attachment: [text/x-patch] warning.diff