Re: Warnings

On Fri, Sep 2, 2011 at 5:30 PM, Wojciech Kupiec <kupiec.w@gmail.com> wrote: > On 09/02/2011 12:33 PM, Paul Dragoonis wrote: >> >> On Fri, Sep 2, 2011 at 10:19 AM, Wojciech Kupiec<kupiec.w@gmail.com> >>  wrote: >>> >>> On 31/08/11 13:08, Paul Dragoonis wrote: >>>> >>>> On Tue, Aug 30, 2011 at 3:28 PM, Paul Dragoonis<dragoonis@gmail.com> >>>>  wrote: >>>>> >>>>> On Tue, Aug 30, 2011 at 3:08 PM, Hannes Magnusson >>>>> <hannes.magnusson@gmail.com>    wrote: >>>>>> >>>>>> On Tue, Aug 30, 2011 at 15:07, Keloran<ava3ar@gmail.com>    wrote: >>>>>>> >>>>>>> I think the warnings should be made abit more obvious >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> http://uk3.php.net/manual/en/language.types.float.php#warn.float-precision >>>>>>> >>>>>>> view that in the alpha-style >>>>>> >>>>>> Excellent catch. >>>>> >>>>> I'll style this up in a pretty box nothing too drastic but eye-catching >>>>> enough. >>>>> >>>> >>>> Here we are, styled it elegantly enough with a nice image on the left. >>>> The patch is a diff of doc.css and the new image added. >>>> Does the diff view somehow include the image or is that only >>>> preview-able via an actual commit? >>>> >>>> Patch attached. >>>> >>>> Regards, >>>> Paul Dragoonis. >>> >>> Paul, >>> >>> That is great that you started working on it! >>> I took a look at this and basically the issues I see are: >>> - The text covers image if you shrink the WB window >>> - The image is cut, in some cases if the content is not height enough >>> - I don't think we need to increase common test size >>> - Maybe having a darker background would be nice >>> - The warning box could be shorter >>> >>> I did some changes, see here: >>> http://wojak.u.bitbit.net/warning-20110902.png >>> (I'm using the old image, please publish the new one) >>> >>> The diff is attached, have a look. >>> >> >> Thanks for the feedback and the mods for when you resize the window and >> such. >> I've taken your mods and made some improvements and applied the image >> again that I originally chose, it sits nicely in the middle left. >> >> I have attached my patch diff, and links to the new warning image on >> tinypic.com and a screenshot of what it looks like: >> >> Diff: (attached) >> Warning Image: http://i56.tinypic.com/v8oopy.png >> Screenshot (on my tiny 13inch macbook pro): >> http://i53.tinypic.com/55pbx0.png >> >> Let me know your thoughts and if happy I can commit and move onto >> something else. > > > Looks really well! > I think it is ok to commit now, do you have commit access? > Yes, committed - lets move this discussion to the commit thread. Thanks ! >