Re: Warnings

On Fri, Sep 2, 2011 at 10:19 AM, Wojciech Kupiec <kupiec.w@gmail.com> wrote: > On 31/08/11 13:08, Paul Dragoonis wrote: >> >> On Tue, Aug 30, 2011 at 3:28 PM, Paul Dragoonis<dragoonis@gmail.com> >>  wrote: >>> >>> On Tue, Aug 30, 2011 at 3:08 PM, Hannes Magnusson >>> <hannes.magnusson@gmail.com>  wrote: >>>> >>>> On Tue, Aug 30, 2011 at 15:07, Keloran<ava3ar@gmail.com>  wrote: >>>>> >>>>> I think the warnings should be made abit more obvious >>>>> >>>>> >>>>> >>>>> http://uk3.php.net/manual/en/language.types.float.php#warn.float-precision >>>>> >>>>> view that in the alpha-style >>>> >>>> Excellent catch. >>> >>> I'll style this up in a pretty box nothing too drastic but eye-catching >>> enough. >>> >> >> Here we are, styled it elegantly enough with a nice image on the left. >> The patch is a diff of doc.css and the new image added. >> Does the diff view somehow include the image or is that only >> preview-able via an actual commit? >> >> Patch attached. >> >> Regards, >> Paul Dragoonis. > > Paul, > > That is great that you started working on it! > I took a look at this and basically the issues I see are: > - The text covers image if you shrink the WB window > - The image is cut, in some cases if the content is not height enough > - I don't think we need to increase common test size > - Maybe having a darker background would be nice > - The warning box could be shorter > > I did some changes, see here: > http://wojak.u.bitbit.net/warning-20110902.png > (I'm using the old image, please publish the new one) > > The diff is attached, have a look. > Thanks for the feedback and the mods for when you resize the window and such. I've taken your mods and made some improvements and applied the image again that I originally chose, it sits nicely in the middle left. I have attached my patch diff, and links to the new warning image on tinypic.com and a screenshot of what it looks like: Diff: (attached) Warning Image: http://i56.tinypic.com/v8oopy.png Screenshot (on my tiny 13inch macbook pro): http://i53.tinypic.com/55pbx0.png Let me know your thoughts and if happy I can commit and move onto something else. Regards, Paul Dragoonis. > > > Wojak > > > -- > PHP Webmaster List Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php >

Index: styles/doc.css =================================================================== --- styles/doc.css (revision 316032) +++ styles/doc.css (working copy) @@ -38,9 +38,7 @@ /* }}} */ - /* {{{ Warning and notes */ -.docs div.warning, .docs div.caution, .docs div.tip, .docs blockquote.note { @@ -56,22 +54,26 @@ border-top: 3px solid #434343; background-color: #EFEFEF; } -.docs div.warning { - border-top: 3px solid #ff4d4d; - background-color: #EFEFEF; -} + .docs div.caution { border-top: 3px solid #F90; background-color: #EFEFEF; } .docs blockquote.note, -.docs div.warning, .docs div.caution, .docs div.tip { font-size: 1em; margin-right: 0.8em; } -.docs div.warning b.warning, +.docs div.warning b.warning { + font-size: 1.7em; +} + +.docs div.warning p { + padding-left: 60px; + text-align: justify; +} + .docs div.caution b.caution, .docs div.tip b.tip { float: left; @@ -83,6 +85,21 @@ .docs div.tip p { margin: 0; } + +.docs div.warning { + text-align: center; + background: #f2e5f4 url('/images/docs-warning.png') left center no-repeat; + margin: 20px 2% 20px 2%; + padding: 5px 15px 5px 19px; + border-top: 3px solid #9f8a8a; + border-bottom: 1px solid #9f8a8a; + min-height: 100px; + background-position: 16px; +} + +.docs div.warning h1{ + font-size: 1.4em; +} /* }}} */ .docs .refentry .methodsynopsis { @@ -109,7 +126,6 @@ /* {{{ Examples (highlighting is in theme.css) */ .docs blockquote.note, -.docs div.warning, .docs div.caution, .docs div.tip .docs .cdata pre, @@ -139,19 +155,19 @@ } .docs .doctable tbody tr:nth-child(even) { - background-color: #EFEFEF; + background-color: #EFEFEF; } .docs .doctable { border-top: 1px solid #9F8A8A; - border-bottom: 1px solid #9F8A8A; + border-bottom: 1px solid #9F8A8A; width: 100%; } .docs .doctable th { background-color: #FCFCFC; text-align: center; - border-bottom: 1px solid #9F8A8A; + border-bottom: 1px solid #9F8A8A; } .docs .doctable td, .docs .doctable th { border-right: 1px solid #9F8A8A ; @@ -300,8 +316,8 @@ .docs .layout-menu ul.child-menu-list a { font-size: 13px; border: 0; - color: black; - line-height: 1; + color: black; + line-height: 1; overflow: visible; margin: 0; padding: 0; @@ -322,6 +338,3 @@ .docs #layout .layout-content, .docs #layout #usernotes { margin-left: 272px; } - - - Index: images/docs-warning.png =================================================================== Cannot display: file marked as a binary type. svn:mime-type = application/octet-stream Property changes on: images/docs-warning.png ___________________________________________________________________ Added: svn:mime-type + application/octet-stream