Req #68711 [NEW]: useless comparisons

From: Date: Fri, 02 Jan 2015 00:34:31 +0000
Subject: Req #68711 [NEW]: useless comparisons
Groups: php.bugs 
Request: Send a blank email to php-bugs+get-189587@lists.php.net to get a copy of this message 
From:             bugreports at internot dot info
Operating system: Linux Ubuntu 14.04
PHP version:      master-Git-2015-01-01 (Git)
Package:          *General Issues
Bug Type:         Feature/Change Request
Bug description:useless comparisons

Description:
------------
Hi,

Multiple reports here:


/ext/standard/pack.c:
749                                                while (--len >= 0) {

len is unsigned, so it can never be <0




In /ext/dba/libflatfile/flatfile.c:

183                if (num < 0) {
num is unsigned
277                if (num < 0)  {
num is unsigned
129                if (num < 0)  {
num is unsigned
229                if (num < 0) {
num is unsigned



Thanks,


T


-- 
Edit bug report at https://bugs.php.net/bug.php?id=68711&edit=1
-- 
Try a snapshot (PHP 5.4):   https://bugs.php.net/fix.php?id=68711&r=trysnapshot54
Try a snapshot (PHP 5.5):   https://bugs.php.net/fix.php?id=68711&r=trysnapshot55
Try a snapshot (trunk):     https://bugs.php.net/fix.php?id=68711&r=trysnapshottrunk
Fixed in SVN:               https://bugs.php.net/fix.php?id=68711&r=fixed
Fixed in release:           https://bugs.php.net/fix.php?id=68711&r=alreadyfixed
Need backtrace:             https://bugs.php.net/fix.php?id=68711&r=needtrace
Need Reproduce Script:      https://bugs.php.net/fix.php?id=68711&r=needscript
Try newer version:          https://bugs.php.net/fix.php?id=68711&r=oldversion
Not developer issue:        https://bugs.php.net/fix.php?id=68711&r=support
Expected behavior:          https://bugs.php.net/fix.php?id=68711&r=notwrong
Not enough info:            https://bugs.php.net/fix.php?id=68711&r=notenoughinfo
Submitted twice:            https://bugs.php.net/fix.php?id=68711&r=submittedtwice
register_globals:           https://bugs.php.net/fix.php?id=68711&r=globals
PHP 4 support discontinued: https://bugs.php.net/fix.php?id=68711&r=php4
Daylight Savings:           https://bugs.php.net/fix.php?id=68711&r=dst
IIS Stability:              https://bugs.php.net/fix.php?id=68711&r=isapi
Install GNU Sed:            https://bugs.php.net/fix.php?id=68711&r=gnused
Floating point limitations: https://bugs.php.net/fix.php?id=68711&r=float
No Zend Extensions:         https://bugs.php.net/fix.php?id=68711&r=nozend
MySQL Configuration Error:  https://bugs.php.net/fix.php?id=68711&r=mysqlcfg

Thread (8 messages)

« previous php.bugs (#189587) next »