Req #68711 [Opn->Csd]: useless comparisons

From: Date: Thu, 08 Jan 2015 08:38:25 +0000
Subject: Req #68711 [Opn->Csd]: useless comparisons
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-189738@lists.php.net to get a copy of this message 
Edit report at https://bugs.php.net/bug.php?id=68711&edit=1

 ID:                 68711
 Updated by:         laruence@php.net
 Reported by:        bugreports at internot dot info
 Summary:            useless comparisons
-Status:             Open
+Status:             Closed
 Type:               Feature/Change Request
 Package:            *General Issues
 Operating System:   Linux Ubuntu 14.04
 PHP Version:        master-Git-2015-01-01 (Git)
 Block user comment: N
 Private report:     N

 New Comment:

Automatic comment on behalf of laruence
Revision: http://git.php.net/?p=php-src.git;a=commit;h=1b4f7c3a771f2bae365190fa4f5d4b9b8aa4cae5
Log: Fixed #68711


Previous Comments:
------------------------------------------------------------------------
[2015-01-02 00:34:31] bugreports at internot dot info

Description:
------------
Hi,

Multiple reports here:


/ext/standard/pack.c:
749                                                while (--len >= 0) {

len is unsigned, so it can never be <0




In /ext/dba/libflatfile/flatfile.c:

183                if (num < 0) {
num is unsigned
277                if (num < 0)  {
num is unsigned
129                if (num < 0)  {
num is unsigned
229                if (num < 0) {
num is unsigned



Thanks,


T



------------------------------------------------------------------------



--
Edit this bug report at https://bugs.php.net/bug.php?id=68711&edit=1

Thread (8 messages)

« previous php.bugs (#189738) next »