Req #68711 [PATCH]: useless comparisons

Edit report at https://bugs.php.net/bug.php?id=68711&edit=1 ID: 68711 Patch added by: mj@php.net Reported by: bugreports at internot dot info Summary: useless comparisons Status: Assigned Type: Feature/Change Request Package: *General Issues Operating System: Linux Ubuntu 14.04 PHP Version: master-Git-2015-01-01 (Git) Block user comment: N Private report: N New Comment: The following patch has been added/updated: Patch Name: 68711-flatfile-joshua-rogers Revision: 1421480645 URL: https://bugs.php.net/patch-display.php?bug=68711&patch=68711-flatfile-joshua-rogers&revision=1421480645 Previous Comments: ------------------------------------------------------------------------ [2015-01-14 18:29:14] bugreports at internot dot info Re-opening due to mixing fix for /ext/dba/libflatfile/flatfile.c bug. Thanks ------------------------------------------------------------------------ [2015-01-09 14:22:01] bugreports at internot dot info Yes, that fixed the pack.c one, but not the flatfile.c one. Thanks, ------------------------------------------------------------------------ [2015-01-08 08:38:25] laruence@php.net Automatic comment on behalf of laruence Revision: http://git.php.net/?p=php-src.git;a=commit;h=1b4f7c3a771f2bae365190fa4f5d4b9b8aa4cae5 Log: Fixed #68711 ------------------------------------------------------------------------ [2015-01-02 00:34:31] bugreports at internot dot info Description: ------------ Hi, Multiple reports here: /ext/standard/pack.c: 749 while (--len >= 0) { len is unsigned, so it can never be <0 In /ext/dba/libflatfile/flatfile.c: 183 if (num < 0) { num is unsigned 277 if (num < 0) { num is unsigned 129 if (num < 0) { num is unsigned 229 if (num < 0) { num is unsigned Thanks, T ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=68711&edit=1