Req #68711 [Asn->Csd]: useless comparisons
| From: | jpauli@php.net | Date: | Tue, 20 Jan 2015 14:12:59 +0000 |
| Subject: | Req #68711 [Asn->Csd]: useless comparisons | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-190074@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=68711&edit=1
ID: 68711
Updated by: jpauli@php.net
Reported by: bugreports at internot dot info
Summary: useless comparisons
-Status: Assigned
+Status: Closed
Type: Feature/Change Request
Package: *General Issues
Operating System: Linux Ubuntu 14.04
PHP Version: master-Git-2015-01-01 (Git)
Block user comment: N
Private report: N
New Comment:
Automatic comment on behalf of git@internot.info
Revision: http://git.php.net/?p=php-src.git;a=commit;h=df67c4e8bd0c7c0f1fc976fad7f6fe5cbc01ef9b
Log: Fix bug #68711 Remove useless checks. 'num' is unsigned and cannot be <0.
Previous Comments:
------------------------------------------------------------------------
[2015-01-17 07:45:08] mj@php.net
The patch I've attached seconds ago has been posted to internals@ by Joshua Rogers on
2015-01-15.
------------------------------------------------------------------------
[2015-01-17 07:44:06] mj@php.net
The following patch has been added/updated:
Patch Name: 68711-flatfile-joshua-rogers
Revision: 1421480645
URL: https://bugs.php.net/patch-display.php?bug=68711&patch=68711-flatfile-joshua-rogers&revision=1421480645
------------------------------------------------------------------------
[2015-01-14 18:29:14] bugreports at internot dot info
Re-opening due to mixing fix for /ext/dba/libflatfile/flatfile.c bug.
Thanks
------------------------------------------------------------------------
[2015-01-09 14:22:01] bugreports at internot dot info
Yes, that fixed the pack.c one, but not the flatfile.c one.
Thanks,
------------------------------------------------------------------------
[2015-01-08 08:38:25] laruence@php.net
Automatic comment on behalf of laruence
Revision: http://git.php.net/?p=php-src.git;a=commit;h=1b4f7c3a771f2bae365190fa4f5d4b9b8aa4cae5
Log: Fixed #68711
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=68711
--
Edit this bug report at https://bugs.php.net/bug.php?id=68711&edit=1