Re: cvs: php4(PHP_4_3) /ext/zlib zlib.c

On Wed, 21 May 2003, Sander Roobol wrote: > sander Wed May 21 12:07:33 2003 EDT > > Modified files: (Branch: PHP_4_3) > /php4/ext/zlib zlib.c > Log: > MFH (ob_gzhandler and zlib.output_compression should send a Content-Length > header if the length of the complete compressed output is known) Why are you still committing features to a release branch? Please revert immediately. Regardless, the patch is very likely flawed -- setting CL has been tried several times, and it was shot down every time. date: 2001/08/16 23:34:25; author: zeev; state: Exp; lines: +4 -4 Send Content-Length if we're sending just one chunk date: 2002/04/27 17:03:32; author: thies; state: Exp; lines: +9 -2 @ - If possible set Content-Length header in zlib.output_compression mode. (thie date: 2002/05/02 01:11:58; author: yohgaki; state: Exp; lines: +4 -19 Move Content-Length: header handling from zlib.c to output.c When output buffer is enabled and header can be sent, Content-Length: header is added always from now on. date: 2002/05/04 23:23:16; author: zeev; state: Exp; lines: +1 -17 We shouldn't force Content-length:, but much worse, it's wrong in many cases (basically, unless you use output buffering to buffer all of your content, it won't work; output buffering is used for lots of different things as a functional interface, and such buffers have no relation to Content-type at all). - Sascha