Re: cvs: php4(PHP_4_3) /ext/zlib zlib.c

As Sascha mentioned already, this patch doesn't look valid for me. zlib.output_complession can be used with chunked buffering and so php_zlib_output_handler() may be called more than once. At that time handled_output_len should be set to the length of the chunk being handled rather than the total length of the content itself. Moriyoshi Moriyoshi > @@ -1027,6 +1046,8 @@ > do_end = (mode & PHP_OUTPUT_HANDLER_END ? 1 : 0); > if (php_deflate_string(output, output_len, handled_output, handled_output_len, > ZLIBG(ob_gzip_coding), do_start, do_end, ZLIBG(output_compression_level) TSRMLS_CC)!=SUCCESS) { > zend_error(E_ERROR, "Compression failed"); > + } else if (do_start && do_end) { > + ADD_CL_HEADER(*handled_output_len); > } handled_output_len should be the number of bytes which has been handled