Re: cvs: php4(PHP_4_3) /ext/zlib zlib.c

Sander Roobol <sander@php.net> wrote: > On Thu, May 22, 2003 at 01:51:59AM +0900, Moriyoshi Koizumi wrote: > > As Sascha mentioned already, this patch doesn't look valid for me. > > zlib.output_complession can be used with chunked buffering and > > so php_zlib_output_handler() may be called more than once. > > At that time handled_output_len should be set to the length of the > > chunk being handled rather than the total length of the content > > itself. > > As far as I can see it's still a valid patch, although it's limited. It > only sends a Content-Length header if the output handler is called once > - that is, if do_start AND do_end are set, if this is the first and the > last call. Zeev made it that way, see the comment above. So it will send > the right Content-Lenght in most cases, and it won't do anything in the > other cases. Okay, it seems I was missing that point. Feel free to apply again the gzip_output_handler portion of your patch. Although, it's still not a good idea to bring it in to ob_gzhandler() as well since the handler is not necessarily in the bottom of ob stack. Moriyoshi